Fix curly-brace-presence edge cases
#2523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ljharb what do you think of this? About the HTML entities, I did what I thought would be the best solution, I would not use that lint if it replaced Please let me know if you the fixes on separate PRs. |
|
@ljharb kind ping as, again, this bug prevents using this lint which is one of the best. I appreciate your help, thank you! |
ljharb
approved these changes
Dec 27, 2019
ljharb
force-pushed
the
fix-other-curly-brace-presence-edge-cases
branch
from
94e608d
to
7f87310
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Formats texts that contain line breaks
Fixes #2524
The example below was not being handled.
Handle HTML entities
Fixes #2522