Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eslint] enable eslint-plugin-eslint-plugin #2469

Merged
merged 1 commit into from Oct 29, 2019

Conversation

golopot
Copy link
Contributor

@golopot golopot commented Oct 20, 2019

Most of the changes are deleting duplicate test cases.

@ljharb ljharb force-pushed the eslint-plugin-eslint-plugin branch from 97d7c2d to 51bb4be Compare October 29, 2019 05:15
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i restored some of the test cases and added alternate parsers instead :-)

@ljharb ljharb force-pushed the eslint-plugin-eslint-plugin branch from 51bb4be to d9d2193 Compare October 29, 2019 05:24
@ljharb ljharb merged commit d9d2193 into jsx-eslint:master Oct 29, 2019
@billyjanitsch
Copy link

@ljharb shouldn't this have been added as a dev dependency, rather than as a dependency?

@ljharb
Copy link
Member

ljharb commented Dec 2, 2019

yes, it should. thanks for the catch (#2510)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants