Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] no-render-return-value should warn when used in assignment expression. #2462

Merged
merged 1 commit into from Oct 12, 2019
Merged

[Fix] no-render-return-value should warn when used in assignment expression. #2462

merged 1 commit into from Oct 12, 2019

Conversation

jichu4n
Copy link
Contributor

@jichu4n jichu4n commented Oct 11, 2019

Addresses #2461 .

With this PR, the no-render-return-value plugin will warn for usages like this:

this.x = ReactDOM.render(...);

or

let y;
...
y = ReactDOM.render(...);

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants