New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow explicit spread of props #2449
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…explicit spread of props Fixes jsx-eslint#2439.
ljharb
requested changes
Oct 6, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could use some examples in the docs.
@ljharb What do you think of prettier? Perhaps it could help us to keep consistent formatting across whole library. |
pawelnvk
force-pushed
the
2439-explicit-spread
branch
from
October 8, 2019 17:52
a156ea3
to
5eba4fb
Compare
ljharb
approved these changes
Oct 8, 2019
ljharb
force-pushed
the
2439-explicit-spread
branch
from
October 8, 2019 21:29
5eba4fb
to
0877bcd
Compare
@pawelnvk no thanks; that’s what eslint is for. |
This was referenced Dec 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to resolve: #2439