Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow explicit spread of props #2449

Merged
merged 1 commit into from Oct 8, 2019

Conversation

pawelnvk
Copy link
Contributor

@pawelnvk pawelnvk commented Oct 5, 2019

PR to resolve: #2439

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could use some examples in the docs.

docs/rules/jsx-props-no-spreading.md Outdated Show resolved Hide resolved
docs/rules/jsx-props-no-spreading.md Outdated Show resolved Hide resolved
docs/rules/jsx-props-no-spreading.md Outdated Show resolved Hide resolved
lib/rules/jsx-props-no-spreading.js Outdated Show resolved Hide resolved
lib/rules/jsx-props-no-spreading.js Outdated Show resolved Hide resolved
@pawelnvk
Copy link
Contributor Author

pawelnvk commented Oct 8, 2019

@ljharb What do you think of prettier? Perhaps it could help us to keep consistent formatting across whole library.

@ljharb ljharb merged commit 0877bcd into jsx-eslint:master Oct 8, 2019
@ljharb
Copy link
Member

ljharb commented Oct 9, 2019

@pawelnvk no thanks; that’s what eslint is for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Don't warn in react/jsx-props-no-spreading when all properties are listed explicitly.
2 participants