[Refactor]: remove unused codes in util/propTypes #2288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove useless handling of `instanceOf` and `oneOf`
There is no special treatment of `Proptypes.{instanceOf, oneOf}` types
so they might as well be handled as unrecognized types.
ljharb
reviewed
May 25, 2019
| }; | ||
| for (let i = 0, j = annotation.types.length; i < j; i++) { | ||
| const type = buildTypeAnnotationDeclarationTypes(annotation.types[i], parentName, seen); | ||
| // keep only complex type |
There was a problem hiding this comment.
can you track down why this was added in the first place? it seems like something that might be important.
There was a problem hiding this comment.
children === true comes from b8e0a4e . But it does not help me understand why it is needed.
ljharb
approved these changes
Jan 5, 2020
ljharb
force-pushed
the
simplify-union-type
branch
from
011d7b0
to
d02bb9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UnionTypeDefinition.childrenhad a inconvenient typeunknown[]|true. It turned outchildren === truenever happens, so the related codes can be removed.