Updating no-target-blank logic to only require no-referrer #2043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
Nov 12, 2018
There was a problem hiding this comment.
Per discussion; it is in no way clear that this is an acceptable change to make.
See #2022 (comment).
|
@ljharb Probably should've noted that I only made this so it's available if the team decides to go through with it. |
|
@ljharb Also shared what I found for research on the issue, I'm not sure if it's actually enough to draw a conclusion from but it seems like a pretty valid source to me. |
|
Reopening per #2022 (comment) |
ljharb
force-pushed
the
no-opener-no-referrer
branch
from
8e34d42
to
f26789d
Compare
|
Rebased this, and kept all existing test cases rather than modifying them. |
ljharb
force-pushed
the
no-opener-no-referrer
branch
2 times, most recently
from
6893aed
to
a8f648a
Compare
ljharb
approved these changes
May 7, 2020
ljharb
force-pushed
the
no-opener-no-referrer
branch
from
a8f648a
to
b9d2eb5
Compare
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2022
Just a minor change to only require
no-referrerrather than bothnoreferrer noopener.