Prevent adjacent inline elements not separated by whitespace. #1155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not separated by whitespace
SeanHayes
force-pushed
the
no-adjacent-inline-elements
branch
2 times, most recently
from
fc3405c
to
1d54da5
Compare
ljharb
reviewed
Apr 20, 2017
SeanHayes
force-pushed
the
no-adjacent-inline-elements
branch
5 times, most recently
from
e82018c
to
6479675
Compare
SeanHayes
commented
Apr 22, 2017
|
|
||
| } | ||
| return { | ||
| JSXElement: function(node) { |
There was a problem hiding this comment.
I wasn't sure how to get this working with React.createElement(), thought I'd figure it out after getting some feedback.
ljharb
force-pushed
the
no-adjacent-inline-elements
branch
from
6479675
to
982a0a1
Compare
ljharb
force-pushed
the
no-adjacent-inline-elements
branch
3 times, most recently
from
4cc3ac9
to
0d7019b
Compare
ljharb
approved these changes
Dec 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI, this is my first time writing an eslint rule.
I wrote this because I want to be warned when I have adjacent inline elements without any whitespace, as it affects the way the page looks when unstyled, and may affect the way search engines see the page.
Let me know if you think any changes are needed. If this is something you're interested in merging I'll add the related docs.