Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnsafeLoader does not use UnsafeConstructor #499

Closed
dthkao opened this issue Feb 15, 2021 · 1 comment
Closed

UnsafeLoader does not use UnsafeConstructor #499

dthkao opened this issue Feb 15, 2021 · 1 comment

Comments

@dthkao
Copy link
Contributor

dthkao commented Feb 15, 2021

Is this intentional?

#472 moves some of the multiconstructors form FullConstructor to UnsafeConstructor and updates tests to use UnsafeLoader (this makes sense), but UnsafeLoader does not inherit UnsafeConstructor (no loader does).

There doesn't seem to be a way to use UnsafeLoader if needed?

+@ingydotnet

@dthkao
Copy link
Contributor Author

dthkao commented Feb 15, 2021

Oof disregard. I now see that Constructor=UnsafeConstructor, and that our broken tests aren't specifying a loader (ew).

@dthkao dthkao closed this as completed Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant