Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ext/_yaml.c is missing in 4.1 tarball #182

Closed
dfroger opened this issue Jun 27, 2018 · 5 comments
Closed

ext/_yaml.c is missing in 4.1 tarball #182

dfroger opened this issue Jun 27, 2018 · 5 comments

Comments

@dfroger
Copy link

dfroger commented Jun 27, 2018

Installing pyyaml 3.12 without cython do build the _yaml extension, but installing 4.1 do not:

python -m venv venv3.12
./venv3.12/bin/pip install pyyaml==3.12

python -m venv venv4.1
./venv4.1/bin/pip install pyyaml==4.1

find . -name '_yaml*'
./venv3.12/lib/python3.6/site-packages/_yaml.cpython-36m-x86_64-linux-gnu.so

The problem is that in https://pypi.org/simple/pyyaml/ PyYAML-3.12.tar.gz contains ext/_yaml.c, but PyYAML-4.1.tar.gz do not, so cython is required for 4.1 to build the extension. (.pyx -> .c)

(question also asked in #179 but the issue was about another problem and is closed)

Could it be possible to make a new 4.1 tarball including ext/_yaml.c?

@ingydotnet
Copy link
Member

Will address soon. #179 (comment)

The-Compiler added a commit to qutebrowser/qutebrowser that referenced this issue Jun 28, 2018
This reverts commit 96defc5.

With PyYAML 4.1 we don't have C extensions on Travis CI:
yaml/pyyaml#179
yaml/pyyaml#182

Unfortunately, cython isn't in the APT whitelist either:
travis-ci/apt-source-safelist#37
@asottile
Copy link
Contributor

@ingydotnet the usual way to fix this is to ensure cython is installed when uploading the release sdist -- a simple version bump and re-upload would fix this issue (and an assertion in setup.py that cython is required during sdist would prevent it in the future)

@asottile
Copy link
Contributor

for instance, here's what shapely does

perlpunk added a commit to perlpunk/pyyaml that referenced this issue Jun 28, 2018
@perlpunk
Copy link
Member

@asottile I created #188, thanks
unfortunately, now travis-ci complains: https://travis-ci.org/yaml/pyyaml/builds/397951551 because of missing cython

@asottile
Copy link
Contributor

@perlpunk I sent a PR to your branch: perlpunk#1

ingydotnet pushed a commit that referenced this issue Jun 28, 2018
and add a warning if cython could not be loaded, but is not required

Fixes #182
ingydotnet pushed a commit that referenced this issue Jun 29, 2018
and add a warning if cython could not be loaded, but is not required

Fixes #182
perlpunk added a commit to perlpunk/pyyaml that referenced this issue Jun 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants