Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate Babel warning in rspec output #1671

Closed
1 task
mikeapp opened this issue Oct 1, 2021 · 3 comments
Closed
1 task

Investigate Babel warning in rspec output #1671

mikeapp opened this issue Oct 1, 2021 · 3 comments
Assignees
Labels
Chore Indicates that PO doesn't need to sign off software engineering

Comments

@mikeapp
Copy link
Collaborator

mikeapp commented Oct 1, 2021

Story

There are multiple instances of a babel warning in the rspec output:

Though the "loose" option was set to "false" in your @babel/preset-env config, it will not be used for @babel/plugin-proposal-private-methods since the "loose" mode option was set to "true" for @babel/plugin-proposal-class-properties.
The "loose" option must be the same for @babel/plugin-proposal-class-properties, @babel/plugin-proposal-private-methods and @babel/plugin-proposal-private-property-in-object (when they are enabled): you can silence this warning by explicitly adding
	["@babel/plugin-proposal-private-methods", { "loose": true }]
to the "plugins" section of your Babel config.

See rails/webpacker#3008

Acceptance

  • Investigate the fix and determine level of effort.
@mikeapp mikeapp added Chore Indicates that PO doesn't need to sign off software engineering labels Oct 1, 2021
@mikeapp mikeapp changed the title Babel warning in rspec output Investigate Babel warning in rspec output Oct 1, 2021
@K8Sewell K8Sewell self-assigned this Oct 5, 2021
@K8Sewell
Copy link

K8Sewell commented Oct 5, 2021

Have a draft PR up that attempted to upgrade webpacker like some of the resolutions offered in the linked webpacker issue but there were still warnings output in the CI spec run so still investigating other offered solutions in that issue thread.

@K8Sewell
Copy link

K8Sewell commented Oct 6, 2021

PR ready for review - yalelibrary/yul-dc-management#804 no more babel output in the CI spec run. I'm not positive upgrading webpacker was essential but doesn't hurt right? I can pull that upgrade out of this PR if that's preferred.

@FCRodriguez7
Copy link
Collaborator

Released management v2.49.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chore Indicates that PO doesn't need to sign off software engineering
Projects
None yet
Development

No branches or pull requests

3 participants