Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console warning on tag addition via enter key #1331

Closed
1 of 3 tasks
gxleano opened this issue Apr 28, 2024 · 1 comment
Closed
1 of 3 tasks

Console warning on tag addition via enter key #1331

gxleano opened this issue Apr 28, 2024 · 1 comment
Labels

Comments

@gxleano
Copy link

gxleano commented Apr 28, 2024

Prerequisites

  • I am running the latest version
  • I checked the documentation and found no answer
  • I checked to make sure that this issue has not already been filed

馃挜 Demo Page

https://jsbin.com/yayukiz/edit?html,js,output

Explanation

When adding a tag on the demo site by pressing the Enter key, a warning message appears in the console: [Tagify]: Cannot find element in Tag template: . .tagify__tag-text. However, this behavior does not occur when clicking instead.

@gxleano gxleano changed the title Console Warning on Tag Addition via Enter Key Console warning on tag addition via enter key Apr 28, 2024
@yairEO yairEO added the Bug label Apr 28, 2024
@gxleano
Copy link
Author

gxleano commented Apr 28, 2024

Seems like this change ff37bbf#diff-3c4c0fff34c73a26f550ccf4ba326621e9651dad00c41c373f6abf384944cf8dR278, was the culprit.

'Enter' case shouldn't be fired from focused dropdown suggestions.

On previous versions it is working as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants