Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced object literals support #39

Merged
merged 2 commits into from Dec 24, 2018
Merged

Enhanced object literals support #39

merged 2 commits into from Dec 24, 2018

Conversation

kwolfy
Copy link
Contributor

@kwolfy kwolfy commented Jul 1, 2018

Unfortunately I could not cover the case with async enhanced object literals, cause in travis CI you have nodejs=4 tests

var obj = { async foo() {} };

Fix #33

@yahoocla
Copy link

yahoocla commented Jul 1, 2018

Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! 😄

@alexander-akait
Copy link

/cc @kwolfy looks it is require accept CLA, can you accept?

@alexander-akait
Copy link

/cc @okuryu can you review PR?

@kwolfy
Copy link
Contributor Author

kwolfy commented Jul 26, 2018

I accepted

@alexander-akait
Copy link

/cc @redonkulus

@krutzler

This comment was marked as outdated.

@alexander-akait
Copy link

/cc @okuryu

@krutzler

This comment was marked as outdated.

@okuryu
Copy link
Collaborator

okuryu commented Dec 18, 2018

OK, let's review.. It seems not to have tests for async syntax. Would you mind adding it?

@alexander-akait
Copy link

@okuryu yep, but we run test on node@4 and it is impossible to test

@kwolfy
Copy link
Contributor Author

kwolfy commented Dec 18, 2018

right

@okuryu
Copy link
Collaborator

okuryu commented Dec 18, 2018

oops! I see 😅

@alexander-akait
Copy link

/cc @okuryu can we merge this and release new version? We have some problems in webpack

@okuryu okuryu merged commit 734e8c7 into yahoo:master Dec 24, 2018
@okuryu
Copy link
Collaborator

okuryu commented Dec 24, 2018

Sorry for delay! I just merged and published serialize-javascript@1.6.0. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not support for Enhanced Object Literals
5 participants