Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Set/Map #12

Closed
quicksnap opened this issue Mar 7, 2016 · 4 comments · Fixed by #45
Closed

Support for Set/Map #12

quicksnap opened this issue Mar 7, 2016 · 4 comments · Fixed by #45

Comments

@quicksnap
Copy link

Would you accept a PR for serializing Set/Map?

@ericf
Copy link
Collaborator

ericf commented Mar 7, 2016

Sure. I'm interested to see how you would rehydrate them…

@quicksnap
Copy link
Author

Off the top of my head, I think Set would be easy enough as new Set([ /* JSON dump of Set*/ ]) I suppose the same could be done for Map, but dehydrating it beforehand as a key/value

@pimterry
Copy link
Contributor

For those interested in this, I've opened a PR (#45) that adds Set & Map support, and published it temporarily as a fork at https://www.npmjs.com/package/@httptoolkit/serialize-javascript.

The fork is just so I can start using it straight away in my own projects before it's merged, but you're welcome to use it/test it from there too in the meantime if this is useful to you as well.

@okuryu
Copy link
Collaborator

okuryu commented Apr 16, 2019

Published serialize-javascript@1.7.0. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants