Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no activity on #115 from @shenoyguru , so I'm opening a new PR with all the changes we need to apply to fix the current security vulnerability. A copied over my original comment with a few small changes. I would recoment releasing 4.0.0 as dropping older node versions could be a breaking change for dependants.
Hi. Recently I got some audit warnings coming from this package's dependencies.
How to reproduce
Create an empty folder and run the following:
Yarn output
or
NPM output
The fix that needs to be applied
yargs
dependency to^17.0.0
(preferably^17.2.1
)yargs
looking for breaking changesyargs
requires>=12
so this package should too).travis.yml
file and add newer node versions (15 & 16)Testing the changes
I ran the tests on these node versions and both
npm test
and./bin/sassgraph descendents test/fixtures test/fixtures/simple/index.scss
looked goodThere are more issues / pull requests trying to solve similar issues: #112, #114 & #115. Some of them are using lower versions, some of them are incomplete.