Update default extensions to match readme.md #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosentmatter
force-pushed
the
master
branch
2 times, most recently
from
f74b0fb
to
c8ef5e0
Compare
|
The read me is wrong. Support for .CSS was removed in a recent major
version bump to comply with the Sass spec.
…On Sat., 20 Jul. 2019, 4:36 am Kevin Lau, ***@***.***> wrote:
https://github.com/xzyfer/sass-graph#extensions
The code didn't include css, but the readme did.
------------------------------
You can view, comment on, or merge this pull request online at:
#106
Commit Summary
- Update default extensions to match readme.md
File Changes
- *M* readme.md
<https://github.com/xzyfer/sass-graph/pull/106/files#diff-0> (2)
- *M* sass-graph.js
<https://github.com/xzyfer/sass-graph/pull/106/files#diff-1> (2)
Patch Links:
- https://github.com/xzyfer/sass-graph/pull/106.patch
- https://github.com/xzyfer/sass-graph/pull/106.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#106?email_source=notifications&email_token=AAENSWAOKOFSUEIOK7THJUTQAICTLA5CNFSM4IFKJQR2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HAK7RAQ>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAENSWCCQVP4DJJAOU7MU4TQAICTLANCNFSM4IFKJQRQ>
.
|
.css has been removed from the default to comply with the Sass spec: https://sass-lang.com/documentation/at-rules/import#importing-css sass/node-sass#2362 https://github.com/sass/libsass/releases/tag/3.5.3
|
Ok, thanks for the information. I updated the PR to fix up the readme instead. Relevant links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/xzyfer/sass-graph#extensions
The code didn't include css, but the readme did.