When available, use resolve data already present in most modules #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xz64 these changes should greatly reduce fs calls for this plugin in all typical cases |
xz64
approved these changes
Jan 22, 2022
|
@markjm Thanks for your contribution! |
|
Thanks - mind cutting a new release? |
|
@markjm This is published in v4.0.1 now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All/most NormalModules carry their
resolveRequestinformation along with them from the initial resolving of the module. When available, we can skip all our processing and fs access for those modules.Doing so broke the current abstraction of a ModuleFileIterator, so I changed it to be an "inner module" iterator to more match what its doing.
You can see the typedef here
https://github.com/markjm/webpack/blob/16784692d3c3a8985327dd9a5665bf319d8aec1b/types.d.ts#L440-L448