Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DelComment #1317

Merged
merged 2 commits into from Aug 19, 2022
Merged

feat: DelComment #1317

merged 2 commits into from Aug 19, 2022

Conversation

NaturalGao
Copy link
Contributor

new DelComment function

PR Details

Description

增加删除批注功能函数 DelComment [#849 ]

Motivation and Context

最近项目有用到这个库,挺棒的一个库!刚好在社群又看到有这么个需求,于是尝试贡献下自己的代码。

How Has This Been Tested

添加了一个单元测试函数

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

new DelComment function
@xuri xuri added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 15, 2022
Copy link
Member

@xuri xuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. I've left some comments.

comment.go Outdated Show resolved Hide resolved
comment.go Outdated Show resolved Hide resolved
comment.go Outdated Show resolved Hide resolved
comment.go Outdated Show resolved Hide resolved
comment.go Outdated Show resolved Hide resolved
comment.go Outdated Show resolved Hide resolved
comment_test.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2022

Codecov Report

Merging #1317 (36a33f0) into master (551fb8a) will increase coverage by 0.00%.
The diff coverage is 95.23%.

@@           Coverage Diff           @@
##           master    #1317   +/-   ##
=======================================
  Coverage   98.47%   98.47%           
=======================================
  Files          31       31           
  Lines       23482    23511   +29     
=======================================
+ Hits        23124    23153   +29     
  Misses        239      239           
  Partials      119      119           
Flag Coverage Δ
unittests 98.47% <95.23%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
drawing.go 99.65% <0.00%> (ø)
picture.go 98.36% <50.00%> (ø)
comment.go 100.00% <100.00%> (ø)
docProps.go 100.00% <100.00%> (ø)
errors.go 100.00% <100.00%> (ø)
excelize.go 99.66% <100.00%> (ø)
stream.go 89.56% <100.00%> (ø)
rows.go 97.39% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@xuri xuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some changes based on your branch.

@NaturalGao
Copy link
Contributor Author

happy weekend! Thank you for your help! @xuri

@xuri xuri merged commit 76f3368 into qax-os:master Aug 19, 2022
@xuri xuri added this to Feature in v2.6.1 Aug 19, 2022
@NaturalGao NaturalGao deleted the natural branch August 19, 2022 15:31
rodoard pushed a commit to sheetrocks/excelize that referenced this pull request Aug 26, 2022
…omment (qax-os#1317)

- Update unit tests for the delete comment
- Add 3 errors function for error messages
xuri pushed a commit to carbin-gun/excelize that referenced this pull request Oct 9, 2022
…omment (qax-os#1317)

- Update unit tests for the delete comment
- Add 3 errors function for error messages
xuri pushed a commit to JDavidVR/excelize that referenced this pull request Jul 11, 2023
…omment (qax-os#1317)

- Update unit tests for the delete comment
- Add 3 errors function for error messages
jenbonzhang pushed a commit to jenbonzhang/excelize that referenced this pull request Oct 22, 2023
…omment (qax-os#1317)

- Update unit tests for the delete comment
- Add 3 errors function for error messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
No open projects
v2.6.1
Feature
Development

Successfully merging this pull request may close these issues.

None yet

3 participants