Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

numFmt cannot handle format "000" #1313

Closed
aschereT opened this issue Aug 9, 2022 · 2 comments
Closed

numFmt cannot handle format "000" #1313

aschereT opened this issue Aug 9, 2022 · 2 comments
Labels
duplicate This issue or pull request already exists

Comments

@aschereT
Copy link

aschereT commented Aug 9, 2022

Description
numFmt does not handle format "000" correctly. In numfmt.go:340, only "0" is handled and not any other zero placeholders.

Steps to reproduce the issue:

  1. Download nfp-test.zip
  2. Extract to a temporary directory
  3. Run go run .

Describe the results you received:

❯ go run .
0 123

The second cell just disappears.

Describe the results you expected:

❯ go run .
0 123
1 456

Output of go version:

go version go1.19 darwin/amd64

Excelize version or commit ID:

v2.6.0

I've bisected it to 4b64b26c52932a51ca97a2bb6bf372a07020e52b

Environment details (OS, Microsoft Excel™ version, physical, etc.):

Darwin mac.local 21.6.0 Darwin Kernel Version 21.6.0: Sat Jun 18 17:07:25 PDT 2022; root:xnu-8020.140.41~1/RELEASE_X86_64 x86_64
@xuri xuri added the duplicate This issue or pull request already exists label Aug 10, 2022
xuri added a commit that referenced this issue Aug 11, 2022
@xuri
This closes #1312, #1313, fix number format issue
8152bbb 
- Add supported options in the docs of the functions `SetSheetPrOptions` and `GetSheetPrOptions`
- Add go1.19 unit test settings, and made the test case compatible with go1.19
- Update dependencies module
@xuri
Copy link
Member

xuri commented Aug 11, 2022

This issue was duplicate with #1312. I have fixed it.

@xuri xuri closed this as completed Aug 11, 2022
@aschereT
Copy link
Author

I don't know why it was filed twice. But thanks a lot for the quick fix!

xuri added a commit to carbin-gun/excelize that referenced this issue Oct 9, 2022
@xuri
This closes qax-os#1312, qax-os#1313, fix number format issue
57c823c 
- Add supported options in the docs of the functions `SetSheetPrOptions` and `GetSheetPrOptions`
- Add go1.19 unit test settings, and made the test case compatible with go1.19
- Update dependencies module
xuri added a commit to JDavidVR/excelize that referenced this issue Jul 11, 2023
@xuri
This closes qax-os#1312, qax-os#1313, fix number format issue
5bf449b 
- Add supported options in the docs of the functions `SetSheetPrOptions` and `GetSheetPrOptions`
- Add go1.19 unit test settings, and made the test case compatible with go1.19
- Update dependencies module
jenbonzhang pushed a commit to jenbonzhang/excelize that referenced this issue Oct 22, 2023
@xuri
This closes qax-os#1312, qax-os#1313, fix number format issue
5fad476 
- Add supported options in the docs of the functions `SetSheetPrOptions` and `GetSheetPrOptions`
- Add go1.19 unit test settings, and made the test case compatible with go1.19
- Update dependencies module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xuri @aschereT