Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numFmt cannot handle format #1312

Closed
aschereT opened this issue Aug 9, 2022 · 1 comment
Closed

numFmt cannot handle format #1312

aschereT opened this issue Aug 9, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@aschereT
Copy link

aschereT commented Aug 9, 2022

Description
numFmt does not handle format "000" correctly. In numfmt.go:340, only "0" is handled and not any other zero placeholders.

Steps to reproduce the issue:

  1. Download npf-test.zip
  2. Extract to a temporary directory
  3. Run go run .

Describe the results you received:

❯ go run .
0 123

Describe the results you expected:

❯ go run .
0 123
1 456

Output of go version:

go version go1.19 darwin/amd64

Excelize version or commit ID:

v2.6.0

Environment details (OS, Microsoft Excel™ version, physical, etc.):

@xuri xuri added bug Something isn't working in progress Working in progress labels Aug 10, 2022
@xuri xuri closed this as completed in 8152bbb Aug 11, 2022
@xuri xuri removed the in progress Working in progress label Aug 11, 2022
@xuri
Copy link
Member

xuri commented Aug 11, 2022

Thanks for your feedback. This issue has been fixed, please upgrade to the master branch code, and this patch will be released in the next version.

xuri added a commit to carbin-gun/excelize that referenced this issue Oct 9, 2022
- Add supported options in the docs of the functions `SetSheetPrOptions` and `GetSheetPrOptions`
- Add go1.19 unit test settings, and made the test case compatible with go1.19
- Update dependencies module
xuri added a commit to JDavidVR/excelize that referenced this issue Jul 11, 2023
- Add supported options in the docs of the functions `SetSheetPrOptions` and `GetSheetPrOptions`
- Add go1.19 unit test settings, and made the test case compatible with go1.19
- Update dependencies module
jenbonzhang pushed a commit to jenbonzhang/excelize that referenced this issue Oct 22, 2023
- Add supported options in the docs of the functions `SetSheetPrOptions` and `GetSheetPrOptions`
- Add go1.19 unit test settings, and made the test case compatible with go1.19
- Update dependencies module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants