Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After update CellHyperLink, GetCellHyperLink won't return the latest link #1217

Closed
CHANTXU64 opened this issue Apr 30, 2022 · 1 comment
Closed
Labels
confirmed This issue can be reproduced
Projects

Comments

@CHANTXU64
Copy link
Contributor

CHANTXU64 commented Apr 30, 2022

Description

After update CellHyperLink, GetCellHyperLink won't return the latest link.

Steps to reproduce the issue:

Run:

func TestUpdateHL (t *testing.T) {
  file := excelize.NewFile()
  err := file.SetCellHyperLink("Sheet1", "A1", "https://github.com", "External")
  if err != nil {
    fmt.Println(err)
  }
  err = file.SetCellHyperLink("Sheet1", "A1", "https://baidu.com", "External")
  if err != nil {
    fmt.Println(err)
  }
  _, link, _ := file.GetCellHyperLink("Sheet1", "A1")
  assert.Equal(t, "https://baidu.com", link)
  file.Close()
}

Describe the results you received:

FAIL
expected: "https://baidu.com"
actual  : "https://github.com"

Output of go version:

go version go1.18.1 linux/amd64

Excelize version or commit ID:

commit 856ee57

Environment details (OS, Microsoft Excel™ version, physical, etc.):
Linux

@xuri xuri added confirmed This issue can be reproduced in progress Working in progress labels May 1, 2022
@xuri xuri closed this as completed in 773d4af May 1, 2022
@xuri
Copy link
Member

xuri commented May 1, 2022

Thanks for your issue, I have fixed it. Please upgrade to the master branch code, and this patch will be released in the next version.

@xuri xuri removed the in progress Working in progress label May 1, 2022
@xuri xuri added this to Feature in v2.6.1 Jul 7, 2022
xuri added a commit to carbin-gun/excelize that referenced this issue Oct 9, 2022
Ref qax-os#1129, make `SetRowStyle` overwrite style of the cells
xuri added a commit to JDavidVR/excelize that referenced this issue Jul 11, 2023
Ref qax-os#1129, make `SetRowStyle` overwrite style of the cells
jenbonzhang pushed a commit to jenbonzhang/excelize that referenced this issue Oct 22, 2023
Ref qax-os#1129, make `SetRowStyle` overwrite style of the cells
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed This issue can be reproduced
Projects
No open projects
v2.6.1
Feature
Development

No branches or pull requests

2 participants