Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error message doesn't respect -nocolor option #1816

Closed
BruceForstall opened this issue Sep 14, 2018 · 1 comment
Closed

Error message doesn't respect -nocolor option #1816

BruceForstall opened this issue Sep 14, 2018 · 1 comment
Labels
Bug A fault in an existing feature Console Runner xunit.v3.runner.console help wanted

Comments

@BruceForstall
Copy link

This error message:

Skipping -html because XSL-T is not supported on .NET Core 1.x

does not respect the -nocolor option. (That is, it emits color codes unconditionally, which show up as garbage in text log files.)

Looks like this code:

        static void Handler_XslTransform(string key, string resourceName, XElement xml, string outputFileName)
        {
#if NETCOREAPP1_0
            ConsoleHelper.SetForegroundColor(ConsoleColor.Yellow);
            Console.WriteLine($"Skipping -{key} because XSL-T is not supported on .NET Core 1.x");
            ConsoleHelper.ResetColor();
#else
@bradwilson bradwilson added Bug A fault in an existing feature help wanted Console Runner xunit.v3.runner.console labels Sep 25, 2018
@eOkadas eOkadas mentioned this issue Oct 1, 2018
Merged
bradwilson pushed a commit that referenced this issue Oct 2, 2018
@eOkadas @bradwilson
#1816 Error message doesn't respect -nocolor option (#1824)
5959d74 
setting a NoColoring bool in TransformFactory
if the related CommandLine switch was used.
this commit was amended to fix missing 'static' keyword
@bradwilson bradwilson mentioned this issue Aug 15, 2020
Closed
@bradwilson
Copy link
Member

Closing this issue, since .NET Core 1.0 will not be supported on v3 (so this error message, and its lack of respect for color issues, is now irrelevant).

This was referenced Mar 12, 2021
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug A fault in an existing feature Console Runner xunit.v3.runner.console help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bradwilson @BruceForstall