Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove workaround for "Use V1 API for templates with new kubernetes client versions" #380

Closed
mnovak1 opened this issue Jul 28, 2020 · 8 comments
Closed

Remove workaround for "Use V1 API for templates with new kubernetes client versions" #380

mnovak1 opened this issue Jul 28, 2020 · 8 comments
Labels
Critical
Milestone
BACKLOG

Comments

@mnovak1
Copy link
Contributor

mnovak1 commented Jul 28, 2020

No description provided.

@mnovak1 mnovak1 self-assigned this Jul 28, 2020
@mchoma
Copy link
Contributor

mchoma commented Jul 31, 2020

fabric8io/kubernetes-client#2373 was fixed, so I believe workaround in xtf is not necessary anymore. Need to be tested

@mnovak1 mnovak1 changed the title Use V1 API for templates with new kubernetes client versions Remove workaround for "Use V1 API for templates with new kubernetes client versions" Aug 3, 2020
@mnovak1
Copy link
Contributor Author

mnovak1 commented Aug 3, 2020

Once new version of kubernetes-client will be released, we'll need to remove workaround made in:
https://github.com/xtf-cz/xtf/pull/374/files

as it will be no longer needed.

@mnovak1
Copy link
Contributor Author

mnovak1 commented Sep 25, 2020

Testing remove of workaround with latest snapshot - https://eap-qe-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/eap-7.x-openshift-product-face/

@mchoma
Copy link
Contributor

mchoma commented Jun 1, 2021

Can we revisit this? It is doing problem in CVP environment where we do not have permission get resource clusterversions.

This is new now as we started to test on OCP 4 cluster in CVP environment.

@mnovak1 mnovak1 removed their assignment Jun 7, 2021
@mnovak1
Copy link
Contributor Author

mnovak1 commented Jun 7, 2021

Unfortunately I don't have capacity to deal with it. Thus unassigning from the issue.

@mchoma
Copy link
Contributor

mchoma commented Jun 9, 2021

For reference fix was already prepared here mnovak1@2698fe9

@mchoma
Copy link
Contributor

mchoma commented Jun 17, 2021

I can't put asignee, but @vsalbaba should have a look.

@mnovak1
Copy link
Contributor Author

mnovak1 commented Mar 2, 2023

Done, closing.

@tommaso-borgato tommaso-borgato added this to the BACKLOG milestone Jun 22, 2023
@mnovak1 mnovak1 closed this as completed Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Critical
Projects
None yet
Milestone
BACKLOG
Development

No branches or pull requests
3 participants
@mnovak1 @mchoma @tommaso-borgato