You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The PR #4298 made it so that an active link under the cursor would be re-evaluated instead of thrown away when the line changes, but we also want to capture this case:
Put cursor above http://example.com/, when a line is added such that the cursor is over the link, the link should get an underline and clicking should activate it, without needing to move the cursor beforehand
This change makes this happen but will result in a lot of work:
@Tyriar Yes the other PR partially fixes the old issue, but not yet for that particular edge case.
Can augment the above, the solution in #4298, some debouncing and possible some other form of caching to save some CPU cycles?
I think so, but the devil might be in details here, how to get proper debouncing working from several terminal actions/states. (Have not yet checked how bad the perf would degrade w'o any debouncing...)
With debouncing we could make it quite small like 50ms as we're just trying to avoid it checking when constant parsing is happening, we would also only want to debounce these refreshes to keep regular mouse moves as responsive as possible as the delay would affect the underline showing up.
The PR #4298 made it so that an active link under the cursor would be re-evaluated instead of thrown away when the line changes, but we also want to capture this case:
Repro:
echo -n "http://example.com/" && sleep 1 && echo -n "a" && sleep 1 && echo -n "b" && sleep 1 && echo -n "c" && sleep 1 && echo -n " x" && sleep 1 && echo -n "x" && sleep 1 && echo "x" && sleep 1 && echo "y" && sleep 1 && echo "y" && sleep 1 && echo "y"
http://example.com/
, when a line is added such that the cursor is over the link, the link should get an underline and clicking should activate it, without needing to move the cursor beforehandThis change makes this happen but will result in a lot of work:
Can augment the above, the solution in #4298, some debouncing and possible some other form of caching to save some CPU cycles?
The text was updated successfully, but these errors were encountered: