Links get wrong position when they are after wide chars with canvas/webgl renderer

[JasonXJ]

See the image below. Note that it only happens to the links detected by the weblinks addon but not OSC 8 links. It also only happens to webgl and canvas renderers but the dom one.

I looked at the code a bit. It seems that the web link addon uses the character position (i.e. "哈" is counted 1 even though it is a wide character) as the the value for IBufferCellPosition.x. Code here. Is this the correct way?

BTW, I am not sure whether this is just #2887.

Details

• Browser and browser version: Chrome 110
• xterm.js version: Tot

[jerch]

The weblink addon is broken in several ways, which is basically the reason for #4288. Maybe check if the issue remains with that PR?

[JasonXJ]

Hi Jerch, your PR works great! It not only fixes this issue, but also 1) works for special shortlink such as http:/b/123456; 2) no longer includes trailing . in the url so that urls in documentation et al. are not messed up.

Can I expect this to be merged soon?

[JasonXJ]

There is still some rendering issue with the DOM renderer (I care much more about the webgl renderer though). See the screenshot below --- my mouse cursor is on the link in the first row.

[jerch]

Can I expect this to be merged soon?

Well it still needs some more test cases, I kinda turned the whole regexp upside-down to also match unicode chars in paths (nowadays supported by all browsers), but this makes match exclusions a bit more cumbersome.

There is still some rendering issue with the DOM renderer ...

Had to fix the DOM renderer offset calc (was totally off with correct cell positions), seems there is still a one off issue at the end of underline.

[jerch]

@JasonXJ Should work now (plz report in #4288, if something is still totally off 🤞)