Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review all event emitters whether they should be registered #4167

Closed
Tyriar opened this issue Oct 1, 2022 · 1 comment · Fixed by #4185
Closed

Review all event emitters whether they should be registered #4167

Tyriar opened this issue Oct 1, 2022 · 1 comment · Fixed by #4185
Assignees
@Tyriar
Labels
type/debt Technical debt that could slow us down in the long run
Milestone
5.1.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Oct 1, 2022

Some are registered, others are not
@Tyriar Tyriar added the type/debt Technical debt that could slow us down in the long run label Oct 1, 2022
@Tyriar Tyriar added this to the 5.1.0 milestone Oct 1, 2022
@Tyriar Tyriar self-assigned this Oct 1, 2022
@Tyriar Tyriar mentioned this issue Oct 1, 2022
Closed
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Oct 8, 2022
@Tyriar
Polish emitter registering in canvas renderer
f88c0e7 
Part of xtermjs#4167
@Tyriar
Copy link
Member Author

Tyriar commented Oct 8, 2022

Fixed in #4185

@Tyriar Tyriar closed this as completed Oct 8, 2022
@Tyriar Tyriar mentioned this issue Oct 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
type/debt Technical debt that could slow us down in the long run
Projects
None yet
Milestone
5.1.0
Development

Successfully merging a pull request may close this issue.

Fix a bunch of memory retention problems Tyriar/xterm.js
1 participant
@Tyriar