Support link position in hover tooltip callback #2470
Conversation
There was a problem hiding this comment.
Thanks @jmbockhorst, I haven't tested it but this looks good. We mainly just need to figure out what naming we want to commit to
There was a problem hiding this comment.
@jmbockhorst let's change the API to use this instead:
interface IViewportRange {
start: IViewportCellPosition;
end: IViewportCellPosition;
}
interface IViewportCellPosition {
col: number;
row: number;
}I created #2480 to make ISelectionPosition more consistent for v5
| matcher.hoverTooltipCallback(e, uri); | ||
| // Note that IViewportRange use 1-based coordinates to align with escape sequences such | ||
| // as CUP which use 1,1 as the default for row/col | ||
| matcher.hoverTooltipCallback(e, uri, { start: { row: y1 + 1, col: x1 + 1 }, end: { row: y2 + 1, col: x2 } }); |
There was a problem hiding this comment.
I made a change to expose this as a 1-based number to align with https://invisible-island.net/xterm/ctlseqs/ctlseqs.html. It's looks a little weird how the end col doesn't add 1 but I guess that's how the mouse zones work right now, they include everything up to but excluding the end cell
There was a problem hiding this comment.
Did you forget col: x2 here? Shouldn't it be col: x2 + 1 as like the others?
|
@mofux the right numbers are coming through like that, I think mouse zone uses coords a little strangely (I wrote it 😅) and the end isn't included in the range |
|
|
Added support for link position in the hover tooltip callback and tested that it works in the demo.
I defined
ILinkLocationin both the public API and the browser types. I know that this probably isn't correct, but I wasn't sure how to get around it. Closes #2468.