Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use ctrl+up/down hack on macOS #2467

Merged
merged 2 commits into from
Oct 14, 2019

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Oct 11, 2019

Fixes #2387

@Tyriar Tyriar added this to the 4.2.0 milestone Oct 11, 2019
@Tyriar Tyriar self-assigned this Oct 11, 2019
@Tyriar Tyriar merged commit cbb79a7 into xtermjs:master Oct 14, 2019
@Tyriar Tyriar deleted the 2387_dont_do_ctrl_arrow_on_mac branch October 14, 2019 18:53
@lgarron
Copy link

lgarron commented Oct 14, 2019

Cheers, thanks so much for the fix! :-D

@Tyriar
Copy link
Member Author

Tyriar commented Oct 15, 2019

@lgarron I'll update vscode so the insiders build will get it tomorrow, would be great if you could verify the fix works right as I'm not a fish user.

@lgarron
Copy link

lgarron commented Mar 13, 2020

@lgarron I'll update vscode so the insiders build will get it tomorrow, would be great if you could verify the fix works right as I'm not a fish user.

I'm a bit late here, but this works perfectly now, thanks! :-D

(There's another bug with oversized text sometimes, but I think it's not related, and it's only visual.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option+up/down sends wrong thing on macOS
2 participants