Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add explicit type to demo/client.ts #1668

Merged
merged 1 commit into from Sep 8, 2018
Merged

add explicit type to demo/client.ts #1668

merged 1 commit into from Sep 8, 2018

Conversation

jerch
Copy link
Member

@jerch jerch commented Sep 8, 2018

Fixes #1667.

Tyriar
Tyriar approved these changes Sep 8, 2018
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, didn't check the CI output with the webpack change

@Tyriar Tyriar added this to the 3.8.0 milestone Sep 8, 2018
@jerch jerch merged commit 0f28ccb into xtermjs:master Sep 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@jerch jerch

Labels
None yet
Projects
None yet
Milestone
3.8.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jerch @Tyriar