Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo does not work on IE11 anymore #1665

Closed
tsl0922 opened this issue Sep 7, 2018 · 8 comments
Closed

Demo does not work on IE11 anymore #1665

tsl0922 opened this issue Sep 7, 2018 · 8 comments
Assignees
Labels
platform/windows type/bug Something is misbehaving
Milestone

Comments

@tsl0922
Copy link
Contributor

tsl0922 commented Sep 7, 2018

The 3.6.0/master version stops to work on IE11.

Details

  • Browser and browser version: Internet Explorer 11.0.9600.17843
  • OS version: Windows 7
  • xterm.js version: 3.6.0/master

Steps to reproduce

  1. Run the demo from master
  2. Open the demo on IE11

Screenshot

image

@Tyriar
Copy link
Member

Tyriar commented Sep 7, 2018

@tsl0922 that error is due to some plugin you have installed, can you try resolve that and check the console? If the demo doesn't work I would expect an error in the console.

@Tyriar Tyriar added this to the 3.7.0 milestone Sep 7, 2018
@tsl0922
Copy link
Contributor Author

tsl0922 commented Sep 7, 2018

@Tyriar The 3.5.0 version works fine on the same browser, I didn't remember I've installed some IE plugins. Also, no error was in the console.

@Tyriar Tyriar added type/bug Something is misbehaving platform/windows labels Sep 7, 2018
@Tyriar
Copy link
Member

Tyriar commented Sep 7, 2018

We'll investigate before the release

@Tyriar Tyriar changed the title Do not work on IE11 anymore Demo does not work on IE11 anymore Sep 8, 2018
@Tyriar
Copy link
Member

Tyriar commented Sep 8, 2018

I looked into this, it's related to changes in the demo using template strings and fat arrow functions. I don't think anything has slipped in which regresses IE support. This may get fixed in #1648

@Tyriar Tyriar modified the milestones: 3.7.0, 3.8.0 Sep 8, 2018
@Tyriar Tyriar self-assigned this Sep 8, 2018
@tsl0922
Copy link
Contributor Author

tsl0922 commented Sep 8, 2018

F12 Developer Tools works again after I installed KB3008923, this is not a xterm.js bug.

@tsl0922 tsl0922 closed this as completed Sep 8, 2018
@Tyriar
Copy link
Member

Tyriar commented Sep 8, 2018

@tsl0922 did you double check that the demo works again in IE11 on the master branch? I merged that PR I mentioned which I expect to fix it, just want to double check.

@Tyriar Tyriar reopened this Sep 8, 2018
@tsl0922
Copy link
Contributor Author

tsl0922 commented Sep 9, 2018

@Tyriar it works now.

@Tyriar
Copy link
Member

Tyriar commented Sep 9, 2018

🎉

@Tyriar Tyriar closed this as completed Sep 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform/windows type/bug Something is misbehaving
Projects
None yet
Development

No branches or pull requests

2 participants