Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparation for project references #1652

Merged
merged 5 commits into from Sep 8, 2018

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Sep 4, 2018

  • Update to TypeScript 3
  • Make common only reference things within common
  • Fix strictNullChecks within common

Part of #1319
Part of #1337

@Tyriar Tyriar added this to the 3.8.0 milestone Sep 4, 2018
@Tyriar Tyriar self-assigned this Sep 4, 2018
@mofux
Copy link
Contributor

mofux commented Sep 6, 2018

I've verified it's still working. LGTM 👍

@mofux mofux self-requested a review September 6, 2018 08:57
@Tyriar
Copy link
Member Author

Tyriar commented Sep 6, 2018

Thanks @mofux will merge these after the release

@Tyriar Tyriar merged commit bdb6647 into xtermjs:master Sep 8, 2018
@Tyriar Tyriar deleted the 1337_project_refs_prep branch September 8, 2018 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants