Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve demo build task #1648

Merged
merged 14 commits into from Sep 8, 2018
Merged

Improve demo build task #1648

merged 14 commits into from Sep 8, 2018

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Sep 2, 2018

This PR does the following:

  • Upgrade webpack to 4
  • Moves the demo build from gulp to npm scripts
  • Instead of relying on concurrently the server and watch tasks are now done within the node script demo/start.js
  • Source maps are inlined in the webpack (dev) build, they don't seem to resolve to src/ yet but they resolve to lib/
  • Client is now in TS and uses xterm.d.ts, we could do this for server in the future (it will complicate the output of the task though). client.ts has its own tsconfig.json but shares the tslint.json

Using webpack is probably the way to go for the core library as well.

@Tyriar Tyriar added this to the 3.8.0 milestone Sep 2, 2018
@Tyriar Tyriar self-assigned this Sep 2, 2018
@mofux
Copy link
Contributor

mofux commented Sep 6, 2018

Tested and verified working. LGTM 👍

@Tyriar Tyriar merged commit 0d89fcd into xtermjs:master Sep 8, 2018
@Tyriar Tyriar deleted the webpack_demo branch September 8, 2018 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants