#957 Link underline should be the same as FG color #1626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
requested changes
Aug 23, 2018
| @@ -187,7 +188,7 @@ export class Linkifier extends EventEmitter implements ILinkifier { | |||
| let text = this._terminal.buffer.translateBufferLineToString(absoluteRowIndex, false); | |||
| let currentIndex = absoluteRowIndex + 1; | |||
| while (currentIndex < this._terminal.buffer.lines.length && | |||
| (<any>this._terminal.buffer.lines.get(currentIndex)).isWrapped) { | |||
There was a problem hiding this comment.
This was intentionally like this as it makes it easier to see it's a wrapped line, not the first in the while loop.
There was a problem hiding this comment.
Need some clarifications here.
If this check will be removed then text variable will contain all lines from visible part of buffer.
This in turn will crash code.
So, I need to know what we trying to achieve by this code change.
There was a problem hiding this comment.
I just mean the 2 extra spaces that were removed 😃
There was a problem hiding this comment.
Ok. I merged latest changes to this branch.
Ready to go! 😃
…-underline-color
…m/xterm.js into fix-underline-color
Tyriar
approved these changes
Aug 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #957.