Error while using fit addon with canvas addon

[FallingSnow]

Using the fit addon with the canvas addon causes an error when calling .fit().

Uncaught TypeError: t is undefined
    _forEachCell xterm-addon-canvas.js:1
    _drawBackground xterm-addon-canvas.js:1
    handleGridChanged xterm-addon-canvas.js:1
    renderRows xterm-addon-canvas.js:1
    _renderRows xterm.js:1
    xterm main.bundle.js:67677
    _innerRefresh xterm.js:1
    xterm main.bundle.js:67677
    refresh xterm.js:1
    refreshRows xterm.js:1
    _fullRefresh xterm.js:1
    xterm main.bundle.js:67677
    fire xterm.js:1
    resize xterm.js:1
    resize xterm.js:1
    resize xterm.js:1
    resize xterm.js:1
    fit xterm-addon-fit.js:1
    observer console.tsx:38
    Console console.tsx:37
    React 8
    workLoop scheduler.development.js:266
    flushWork scheduler.development.js:239
    performWorkUntilDeadline scheduler.development.js:533
    scheduler main.bundle.js:61902
    scheduler main.bundle.js:61964
    Webpack 16

Details

• Browser and browser version: Firefox 115
• xterm.js version: 5.2.1

Steps to reproduce

1. npm install xterm xterm-addon-fit xterm-addon-canvas

let terminal = new Terminal();
let fitAddon = new FitAddon();
terminal.loadAddon(fitAddon);
terminal.loadAddon(new CanvasAddon());
fitAddon.fit();

[Tyriar]

Any more info on this? I tried and could not reproduce in Chrome or Firefox.

I used these two files:

index.html:

<script src="./node_modules/xterm/lib/xterm.js"></script>
<script src="./node_modules/xterm-addon-canvas/lib/xterm-addon-canvas.js"></script>
<script src="./node_modules/xterm-addon-fit/lib/xterm-addon-fit.js"></script>
<script src="./index.js"></script>

index.js:

let terminal = new Terminal();
let fitAddon = new FitAddon.FitAddon();
terminal.loadAddon(fitAddon);
terminal.loadAddon(new CanvasAddon.CanvasAddon());
fitAddon.fit();

[FallingSnow]

This seems to be caused by me using xterm in react with StrictMode which causes components to double render. This error suggests that there is something I wasn't cleaning up in my code.

Is it possible to call .open(element) again on a terminal which .dispose() was called. And do you need to reload all addons after calling dispose?

[Tyriar]

If you call dispose you cannot use it again, you can call open on different elements though.

[jerch]

Do we need to emphasize the dtor-like usage of dispose more? Not even sure where to put it, maybe some docs section about fundamental API ideas?