Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.3.8 is not working as intended for draft/prerelease #41

Closed
RadxaYuntian opened this issue Nov 9, 2022 · 5 comments
Closed

1.3.8 is not working as intended for draft/prerelease #41

RadxaYuntian opened this issue Nov 9, 2022 · 5 comments
Assignees
@owent
Labels
bug Something isn't working

Comments

@RadxaYuntian
Copy link
Contributor

Create empty non draft prerelease first.
https://github.com/RadxaYuntian/upload-to-github-release/commit/5726e7219f5ac39acf13c0e7cbcdd3109c0be067: prerelease become draft
https://github.com/RadxaYuntian/upload-to-github-release/commit/52c25db546343c9cd600ba50b5e9dc505ab5a2db: prerelease become release
@owent owent self-assigned this Nov 10, 2022
@owent owent added the help wanted Extra attention is needed label Nov 10, 2022
@owent
Copy link
Member

owent commented Nov 10, 2022 •
edited

You should put xresloader/upload-to-github-release just after softprops/action-gh-release but in the same job. Or xresloader/upload-to-github-release may run before softprops/action-gh-release. xresloader/upload-to-github-release will not change these options only when update a existed release, or it will create a new release with default options(which means draft and prerelease are both false).

@RadxaYuntian
Copy link
Contributor Author

You should put xresloader/upload-to-github-release just after softprops/action-gh-release but in the same job. Or xresloader/upload-to-github-release may run before softprops/action-gh-release.

I have set up needs so upload-to-github-release always run after action-gh-release is done.

@RadxaYuntian
Copy link
Contributor Author

I have created a new workflow according to what you said, and this one changed prerelease to draft as well:
image

@owent owent added the bug Something isn't working label Nov 10, 2022
@owent
Copy link
Member

owent commented Nov 10, 2022

Thanks and it's fixed in v1.3.9 now.
I have create a test at https://github.com/xresloader/upload-to-github-release-test/blob/main/.github/workflows/release.yml

@owent owent closed this as completed Nov 10, 2022
@owent owent removed the help wanted Extra attention is needed label Nov 10, 2022
@RadxaYuntian
Copy link
Contributor Author

Confirmed working on my 2 test cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@owent owent

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@owent @RadxaYuntian