Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for GitHub Markdown Alerts #774

Closed
xoofx opened this issue Feb 20, 2024 · 3 comments · Fixed by #776
Closed

Add support for GitHub Markdown Alerts #774

xoofx opened this issue Feb 20, 2024 · 3 comments · Fixed by #776

Comments

@xoofx
Copy link
Owner

xoofx commented Feb 20, 2024

See https://github.com/orgs/community/discussions/16925

> [!NOTE]  
> Highlights information that users should take into account, even when skimming.

> [!TIP]
> Optional information to help a user be more successful.

> [!IMPORTANT]  
> Crucial information necessary for users to succeed.

> [!WARNING]  
> Critical content demanding immediate user attention due to potential risks.

> [!CAUTION]
> Negative potential consequences of an action.

rendered as:

Note

Highlights information that users should take into account, even when skimming.

Tip

Optional information to help a user be more successful.

Important

Crucial information necessary for users to succeed.

Warning

Critical content demanding immediate user attention due to potential risks.

Caution

Negative potential consequences of an action.

@jorge-moreira
Copy link

Hi Alexandre,

The objective here is to support a new type of block (i.e. AlertBlock) with it's own parser and renderer?
For the parser I would say that there's no doubt on what to do, although for the renderer I've some doubts on how we would support this to be rendered in html.

I'll be glad to help on.

@xoofx
Copy link
Owner Author

xoofx commented Mar 4, 2024

Added a tentative PR #776 to implement this feature.

@xoofx
Copy link
Owner Author

xoofx commented Mar 4, 2024

The objective here is to support a new type of block (i.e. AlertBlock) with it's own parser and renderer? For the parser I would say that there's no doubt on what to do, although for the renderer I've some doubts on how we would support this to be rendered in html.

I'll be glad to help on.

Forgot to respond, as I was reading your question yesterday, and I started to play with a parser to see how problematic it would be to implement it and saw that it was in the end relatively small, so decided to complete the implementation. So, my apologies if I took over and thanks for the proposal for helping, I appreciate. 🙂

bagusnl added a commit to CollapseLauncher/Collapse that referenced this issue Mar 20, 2024
Markdig
- Add support for GitHub markdown alert
xoofx/markdig#774

- WASDK
seems to only documentation changes and some dependencies update...
microsoft/WindowsAppSDK@v1.5.0...v1.5.1
neon-nyan pushed a commit to CollapseLauncher/Collapse that referenced this issue Mar 20, 2024
(waifu2x) Handle Vulkan initialization exception

(waifu2x) Fix crash when exiting from console

(waifu2x) Fix black output checker

Fix NullReferenceException while trying to get alt. CDN stream

Fix exception while generating local app notification

[skip ci] Sync translation Translate en_US.json in id_ID

100% reviewed source file: 'en_US.json'
on 'id_ID'.

[skip ci] Sync translation Translate en_US.json in fr_FR [Manual Sync]

100% reviewed source file: 'en_US.json'
on 'fr_FR'.

Check process existence for GameBoost

Fix join Discord button crash

(GLC) Disable spellcheck on commands input textbox

Fix tray icon not disposed on close

Also contains failed attempt at fixing multi instance tray icon

Add AssemblyName to properties

Organize InvokeProp.cs

(TrayIcon) Use SecondWindow mode on Preview

Update NuGet(s)

Markdig
- Add support for GitHub markdown alert
xoofx/markdig#774

- WASDK
seems to only documentation changes and some dependencies update...
microsoft/WindowsAppSDK@v1.5.0...v1.5.1

Remove unused arm64 lib after build

Bump version

Remove space on AssemblyName

Move close method to use CloseApp()

Also do the same for TrayIcon stuff

Get the ref pointer to the array explicitly in BSDiff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants