Preserve handler filters if present (allows Filter(s) to work with coloredlogs) #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xolox
added a commit
that referenced
this pull request
Dec 10, 2020
|
Hi @eblis and thanks for the pull request. I've just published coloredlogs release 14.3 which incorporates these changes. Cheers! |
bors bot
added a commit
to duckinator/bork
that referenced
this pull request
Dec 10, 2020
220: Update coloredlogs to 15.0 r=duckinator a=pyup-bot This PR updates [coloredlogs](https://pypi.org/project/coloredlogs) from **14.0** to **15.0**. <details> <summary>Changelog</summary> ### 15.0 ``` ---------------------------- Don't enable system logging on MacOS and Windows anymore. This is backwards incompatible (which is why I'm bumping the major version number) however the old behavior has been reported to be rather problematic (see :func:`~coloredlogs.syslog.is_syslog_supported()` for details) so this seems like the best choice. .. _Release 15.0: xolox/python-coloredlogs@14.2...15.0 ``` ### 14.3 ``` ---------------------------- Merged pull request `89`_ which enhances :func:`coloredlogs.install()` to preserve the filters on handlers that are replaced by :pypi:`coloredlogs`. .. _Release 14.3: xolox/python-coloredlogs@14.2...14.3 .. _89: xolox/python-coloredlogs#89 ``` ### 14.2 ``` ---------------------------- Honor the ``$NO_COLOR`` environment variable as suggested in issue `88`_. .. _Release 14.2: xolox/python-coloredlogs@14.1...14.2 .. _88: xolox/python-coloredlogs#88 ``` ### 14.1 ``` ---------------------------- **Bug fixes:** - Don't allow interactive terminal detection to disable colored text when colored text is being forced by the caller (reported in issue `84`_). - Automatically disable colored text when logging output is being redirected to a file in such a way that it actually works 😬 (reported in issue `100`_). **Other changes:** - Start testing on PyPy 3 (because why not?) .. _Release 14.1: xolox/python-coloredlogs@14.0...14.1 .. _84: xolox/python-coloredlogs#84 .. _100: xolox/python-coloredlogs#100 ``` </details> <details> <summary>Links</summary> - PyPI: https://pypi.org/project/coloredlogs - Changelog: https://pyup.io/changelogs/coloredlogs/ - Docs: https://coloredlogs.readthedocs.io </details> Co-authored-by: pyup-bot <github-bot@pyup.io> Co-authored-by: Ellen Marie Dash <me@duckie.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for issue #32 which I've recently encountered myself.
I was able to trace the problem to the way the handlers are replaced, that's when any existing filters get discarded.
The fix is to preserve the existing filters and apply them back once the new handler has been created