Clarify Prettier defaulting behavior #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This definitely sent me down a rabbit hole: xojs#614
|
sindresorhus
changed the title
PR welcome |
|
I would argue that XO should not be changing these defaults, but it's probably not worth the breaking change for existing consumers. Maybe there's a way to detect an upgrade and then just modify the users prettier config, or just print a warning. |
|
Changing the defaults is very much intentional. |
devinrhode2
added a commit
to devinrhode2/xo
that referenced
this pull request
Oct 15, 2021
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
devinrhode2
added a commit
to devinrhode2/xo
that referenced
this pull request
Oct 15, 2021
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This definitely sent me down a rabbit hole: #614
TODO:
bracketSameLine. XO Does not need to set it tofalse, since that is prettier's current default. (I'm assuming it was different in the past).2. Verify this actually works, check when errors are actually thrownChanging
bracketSpacingactually works! :)