Remove fs-extra dependency
#597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1000ch
force-pushed
the
refactor/remove-fs-extra
branch
2 times, most recently
from
a84c31b
to
9f639d4
Compare
|
Tests are failing |
1000ch
force-pushed
the
refactor/remove-fs-extra
branch
from
50692f5
to
9f639d4
Compare
Umm, cannot reproduce in my local environment... 👀 |
1000ch
force-pushed
the
refactor/remove-fs-extra
branch
from
9f639d4
to
10b6780
Compare
1000ch
force-pushed
the
refactor/remove-fs-extra
branch
from
10b6780
to
eb62414
Compare
|
Thanks :) |
devinrhode2
added a commit
to devinrhode2/xo
that referenced
this pull request
Oct 15, 2021
This reverts commit 098a594.
devinrhode2
pushed a commit
to devinrhode2/xo
that referenced
this pull request
Oct 15, 2021
devinrhode2
pushed a commit
to devinrhode2/xo
that referenced
this pull request
Oct 15, 2021
|
Can you guys elaborate on the benefit of reducing dependencies? I guess install is slightly faster.. and yeah "fewer dependencies" makes it more robust I wish node returned file contents as utf8 strings by default... maybe we should have a I'm working on some scripts of my own and just curious what you guys think is "good" or "best" practice here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The usage of
fs-extrais only related to reading/writing JSON currently, then they can be replaced with some combinations of native modules to reduce the dependency.