Support xo.config.cjs and .xo-config.cjs
#561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You need to update https://github.com/xojs/xo#config |
sindresorhus
changed the title
xo.config.cjs and .xo-config.cjs
- Fixes `ERR_REQUIRE_ESM` error from `cosmiconfig`. - Enables using `xo.config.cjs`/`.xo-config.cjs` in ESM packages with `"type": "module"`. Fixes #468. See - #468 - https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c Sample error output; problem fixed by this commit. ```text Error [ERR_REQUIRE_ESM]: Must use import to load ES Module: /my-code/.xo-config.js require() of ES modules is not supported. require() of /my-code/.xo-config.js from /my-code/node_modules/cosmiconfig/dist/loaders.js is an ES module file as it is a .js file whose nearest parent package.json contains "type": "module" which defines all .js files in that package scope as ES modules. Instead rename .xo-config.js to end in .cjs, change the requiring code to use import(), or remove "type": "module" from /my-code/package.json. ```
|
@sindresorhus: yup. Now added/mentioned the |
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ERR_REQUIRE_ESMerror fromcosmiconfig.xo.config.cjs/.xo-config.cjsin ESM packages with"type": "module".Fixes #468.
See
Sample error output; problem fixed by this commit.
It's a start, but I don't think this fix is a golden bullet for ESM modules depending on
xo. It fixes small-ish test cases without issue, but mixing ESM/non-ESM code may very well lead to further issues.