Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with prettier #542

Closed
fisker opened this issue May 10, 2021 · 2 comments · Fixed by #588
Closed

Issue with prettier #542

fisker opened this issue May 10, 2021 · 2 comments · Fixed by #588

Comments

@fisker
Copy link
Contributor

fisker commented May 10, 2021

eslint-config-prettier already merged all configs into one, so these are useless now.

eslint-plugin-prettier has extra rules disabled, we should use plugin:prettier/recommended instead IMO. More details see this

I don't really use xo, so I'm not sure what's the best.

@DSBUGAY2
Copy link

lib/options-manager.js

@nerdstep
Copy link

nerdstep commented May 21, 2021

eslint-config-prettier\flowtype.js now throws an error if used, so XO (v0.40.1) is currently broken for me...

Error: Cannot read config file: ...\node_modules\eslint-config-prettier\flowtype.js
Error: "prettier/flowtype" has been merged into "prettier" in eslint-config-prettier 8.0.0. See: https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md#version-800-2021-02-21
Referenced from: BaseConfig
    at Object.<anonymous> (...\node_modules\eslint-config-prettier\flowtype.js:1:7)
    at Module._compile (internal/modules/cjs/loader.js:999:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
    at Module.load (internal/modules/cjs/loader.js:863:32)
    at Function.Module._load (internal/modules/cjs/loader.js:708:14)
    at Module.require (internal/modules/cjs/loader.js:887:19)
    at module.exports (...\node_modules\import-fresh\index.js:32:59)
    at loadJSConfigFile (...\node_modules\@eslint\eslintrc\lib\config-array-factory.js:225:16)
    at loadConfigFile (...\node_modules\@eslint\eslintrc\lib\config-array-factory.js:309:20)
    at ConfigArrayFactory._loadConfigData (...\node_modules\@eslint\eslintrc\lib\config-array-factory.js:609:42)

Commenting out the lines @fisker referenced fixes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants