Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update devDependency ava from v1.1.0 to v3.9.0 #490

Merged
merged 2 commits into from Jul 3, 2020

Conversation

bjornstar
Copy link
Contributor

There were 3 changes required to update the ava devDependency from v1.1.0 to v3.9.0:

  1. ava no longer automatically supports ESM syntax. We need to add esm to devDependencies and add some configuration to instruct ava to use the esm library.

  2. The acceptable arguments for messages has been restricted to strings. In a two different tests the results object was used as the message. Removing the message matches the usage in the majority of tests.

  3. The signature for the expectation argument in throws has changed and now requires an object. In one case a regex was used. Moving the regex into the message property on resolved the issue.

@sindresorhus sindresorhus merged commit 7d015ac into xojs:master Jul 3, 2020
@bjornstar bjornstar deleted the update-ava branch July 4, 2020 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants