Add support for scoped shareable configs #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #479 by adding a check to see if the name of the module starts with
@. If so, it'll return the name and attempt to resolve the module as is.I've added to the "buildConfig: extends" test for testing. I've also tested and confirmed that this works in my own project using a scoped module.
It's worth noting that eslint accepts
@scope,@scope/eslint-config, and@scope/eslint-config-my-configwith the extends option (docs). The goal of this PR is to allow for these cases to be used just as they can be in an eslint config.