Svelte files are ignored (no error)

[fregante]

Follows #428

Tested on XO 0.29.1 and Node 12.15

This is the relevant configuration suggested on https://github.com/sveltejs/eslint-plugin-svelte3#installation

{
  "xo": {
    "extensions": [
      "svelte"
    ],
    "plugins": [
      "svelte3"
    ],
    "overrides": [
      {
        "files": [
          "**/*.svelte"
        ],
        "processor": "svelte3/svelte3"
      }
    ]
  }
}

Svelte files are ignored, no error appears.
Even if I set "processor": "blah", no errors.
Even if move processor to xo instead of xo.overrides, no errors.
Even if there are simple whitespace errors in the svelte files.

I'd expect XO to at least try loading Svelte files (thanks to the extensions config) and fail, but nothing at all happens.

Not a minimal repro but here's the repo: https://github.com/hankxdev/one-click-extensions-manager/tree/svelte-eslint

[fregante]

For comparison, I tried this eslint config:

module.exports = {
    parserOptions: {
        ecmaVersion: 2019,
        sourceType: 'module'
    },
    extends: "eslint:recommended",
    env: {
        es6: true,
        browser: true
    },
    plugins: [
        'svelte3'
    ],
    overrides: [{
        files: ['**/*.svelte'],
        processor: 'svelte3/svelte3'
    }]
};

and I do get these errors:

❯ npx eslint src/*.svelte --ext svelte

./src/App.svelte
   8:14  error  'chrome' is not defined                   no-undef
   9:18  error  'chrome' is not defined                   no-undef
  14:6   error  'optionsShown' is defined but never used  no-unused-vars
  40:23  error  'browser' is not defined                  no-undef
  67:25  error  'event' is defined but never used         no-unused-vars

./src/Extension.svelte
  12:18  error    'chrome' is not defined                      no-undef
  15:28  error    'event' is defined but never used            no-unused-vars
  19:4   error    'browser' is not defined                     no-undef
  24:28  error    'event' is defined but never used            no-unused-vars
  25:3   error    'browser' is not defined                     no-undef
  58:3   warning  A11y: <a> element should have child content  a11y-missing-content
  62:4   warning  A11y: <a> element should have child content  a11y-missing-content
  64:3   warning  A11y: <a> element should have child content  a11y-missing-content

When I run it without the overrides I do get these errors:

❯ npx eslint src/*.svelte --ext svelte

./src/App.svelte
  1:1  error  Parsing error: Unexpected token <

./src/Extension.svelte
  1:1  error  Parsing error: Unexpected token <

✖ 2 problems (2 errors, 0 warnings)

Whereas a very explicit xo src/App.svelte --extension=svelte only exits with 0

Also available in the repro repo: https://github.com/hankxdev/one-click-extensions-manager/tree/svelte-eslint

[floer32]

Does a maintainer have a suggestion about this? I am hitting the same thing, wondering if I'm missing something subtle.

[sindresorhus]

The extension option was fixed in 35e6336.

[sindresorhus]

https://github.com/xojs/xo/releases/tag/v0.36.0

[fregante]

extensions: ['svelte'] and processor: "svelte3/svelte3" confirmed to work. Thanks!