Temporarily disable the unicorn/string-content rule
#462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually I don't think this can be enabled in XO at all and sindresorhus/eslint-plugin-unicorn#681 (whitelisting) would be a better user-facing solution. Maaaaybe via whitelist XO could include a configuration for "definitely user-facing" strings like:
|
|
I don't think this PR is needed as we changed the rule to include no patterns by default: sindresorhus/eslint-plugin-unicorn@08fad55 |
|
Uhm? Yeah, that’s the rule itself, but XO does configure the rule right here |
|
I was confused which repo I was on. |
|
Can you comment it out instead of removing it completely? |
sindresorhus
changed the title
unicorn/string-contentunicorn/string-content rule
This was referenced May 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all strings are user-facing so a blanket "replace all ... with …" can break all non-tagged strings.
As reported in #439 (comment)