Add TS extends after base XO extends and before user extends #453
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #446 (comment)
This essentially revert #451 and #442 that weren't the correct fixes.
Instead we now add the typescript specific extends after the base XO config and before the user extends.
This allow
eslint-config-xo-typescript
to override some rules fromeslint-config-xo
and users to extend a config that override rules from botheslint-config-xo-typescript
andeslint-config-xo
.@EdJoPaTo can you confirm this fix the issues reported?