0.28.1 breaks support for space option in typescript

[EdJoPaTo]

I assume #442 overrides the options set by space.

npm i xo@0.28.0 && npx xo works fine.
npm i xo@0.28.1 && npx xo does not.

[sindresorhus]

// @pvdlg

[pvdlg]

For Typescript files we set the rule @typescript-eslint/indent explicitly based on the XO space option:

xo/lib/options-manager.js

Line 285 in 2e39794

config.rules['@typescript-eslint/indent'] = ['error', spaces, {SwitchCase: 1}];

So not surer what is the problem you are reporting.

Can you provide a reproductible case with your config, the file you lint and what report you get and expect?

[EdJoPaTo]

create a temp folder, put in a ts file, for example index.ts with this content:

export function foo(): void {
  console.log('bar');
}

and a package.json with this content

{
  "name": "xo-testing",
  "xo": {
    "space": 2
  }
}

Then run these two commands:

npm i xo@0.28.0 && npx xo
npm i xo@0.28.1 && npx xo

Using 0.28.0 this works fine without errors.
0.28.1 reports for the rule 'indent' (which is only javascript specific, not for typescript) for expected tabs.

Also: In #446 I added test cases for the space option which are failing on 0.28.1 and work on 0.28.0.

[pvdlg]

Thanks! Will look into that tonight

[pvdlg]

So the problem is the indent rule is set in the default XO config: https://github.com/xojs/eslint-config-xo/blob/06e4e1416bdbf2df56984adca8039683ebad735c/index.js#L305

So as a result for TS files we end up with both indent and @typescript-eslint/indent to be set up.

Fixing xojs/eslint-config-xo-typescript#23 will solve the issue

[pvdlg]

Never mind my last comment, the indent rule is not part of those.