Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix assertj usage in CompareAssert helper #210

Merged
merged 1 commit into from Dec 21, 2020
Merged

Fix assertj usage in CompareAssert helper #210

merged 1 commit into from Dec 21, 2020

Conversation

f-lopes
Copy link
Contributor

@f-lopes f-lopes commented Dec 20, 2020

Fix assertj usage in CompareAssert helper.

Build (https://travis-ci.org/github/f-lopes/xmlunit/builds/750682799) passed.

@coveralls
Copy link

coveralls commented Dec 20, 2020 •
edited

Coverage Status

Coverage remained the same at 91.948% when pulling 45bf4ec on f-lopes:fix-compare-assert-assertj-usage into d0029bd on xmlunit:main.

@bodewig bodewig merged commit e99d702 into xmlunit:main Dec 21, 2020
@bodewig
Copy link
Member

bodewig commented Dec 21, 2020

Ouch, thanks, will cut a new release immediately.

bodewig added a commit that referenced this pull request Dec 21, 2020
@bodewig
recored @f-lopes change, closes #210
d9e1613
@bodewig bodewig added this to the 2.8.2 milestone Dec 21, 2020
@f-lopes
Copy link
Contributor Author

f-lopes commented Dec 21, 2020

Thanks for your reactivity!

@bodewig bodewig mentioned this pull request Feb 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
AssertJ 3.x Support bug
Projects
None yet
Milestone
2.8.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@f-lopes @coveralls @bodewig