Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Jakarta XML Binding #186

Merged
merged 1 commit into from Jun 7, 2020
Merged

Use Jakarta XML Binding #186

merged 1 commit into from Jun 7, 2020

Conversation

endrejeges
Copy link
Contributor

JAXB project has been moved into the Eclipse Jakarta project, and the maven coordinates have been changed. The migration has been followed already by several project (Eg. spring-boot), which is causing duplicate classes coming from different dependency jars.

Changes:

  • Added the Jakarta XML Binding API (jakarta.xml.bind:jakarta.xml.bind-api:2.3.3) and runtime (org.glassfish.jaxb:jaxb-runtime:2.3.3) to the Java 9+ profiled builds

  • Removed the Old JAXB API and runtimes

  • Removed from the pom.xml the javax.activation:activation:1.1.1 dependency, because the JAXB API defines this dependency as jakarta.activation:jakarta.activation-api:1.2.2. Due to this Java Activation Framework has become a new transitive dependency of XMLUnit, but it is compile dependency of the JAXB API, so it would be needed anyway somewhere to make XMLUnit work, at least the dependency is now explicit. I guess this did not caused any problem so far because the JAXB runtime transitively included it.

  • The JAXB runtime is now a runtime scoped dependency (it is still optional, because others might use another implementation).

  • The "jakarta.xml.bind.version" maven property has been introduced to enforce consistency of the API and runtime dependencies.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.823% when pulling 99210b7 on endrejeges:jakarta-dependencies into e2fda17 on xmlunit:master.

@bodewig bodewig added this to the 2.8.0 milestone Jun 7, 2020
bodewig added a commit that referenced this pull request Jun 7, 2020
@bodewig bodewig merged commit 99210b7 into xmlunit:master Jun 7, 2020
@bodewig
Copy link
Member

bodewig commented Jun 7, 2020

Thanks, I've adjusted the minor version to reflect the change is a non-trivial one.

@endrejeges endrejeges deleted the jakarta-dependencies branch June 7, 2020 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants