Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update assertj+tests work with other locales #180

Conversation

asturio
Copy link

@asturio asturio commented Apr 14, 2020

Dependencies updated:

  • maven-assembly-plugin 3.0.0 -> 3.2.0 (bogus warning)
  • assert 2.9.0 -> 3.15.0

AssertJ Unittests run on other locales

  • Some Tests expect Messages in english, and running them on other locales
    won't work. So the test-classes set the locale to english before the tests
    and restore them after the tests

- maven-assembly-plugin 3.0.0 -> 3.2.0 (bogus warning)
- assert 2.9.0 -> 3.15.0
- Some Tests expect Messages in english, and running them on other locales
  won't work. So the test-classes set the locale to english before the tests
  and restore them after the tests
@coveralls
Copy link

coveralls commented Apr 14, 2020

Coverage Status

Coverage increased (+0.7%) to 92.461% when pulling f5f77fd on asturio:update-assertj+tests-work-with-other-locales into 4866621 on xmlunit:master.

- as original code
@bodewig
Copy link
Member

bodewig commented Apr 15, 2020

Many thanks @asturio .

This module depends on AssertJ 2.x in order to be buildable with Java7 - see https://travis-ci.org/github/xmlunit/xmlunit/jobs/675025927. I don't think your changes really require us updating the dependency. Could you please revert that part?

Also please add a license header to the new LocaleModifier file.

What you are doing with LocaleModifier and Before/AfterClass looks like a candidate for a JUnit TestRule annotated with ClassRule to me.

@bodewig bodewig closed this in c5f1899 Apr 28, 2020
@bodewig
Copy link
Member

bodewig commented Apr 28, 2020

After re-installing my OS I'm now facing the same problem :-)

I've decided to take a slightly different approach, though. See c5f1899

Many thanks!

@asturio asturio deleted the update-assertj+tests-work-with-other-locales branch October 19, 2020 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants