Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support java.nio.file.Path as input source #196

Closed
gastaldi opened this issue Sep 15, 2020 · 1 comment
Closed

Support java.nio.file.Path as input source #196

gastaldi opened this issue Sep 15, 2020 · 1 comment
Labels
core enhancement good first issue
Milestone
2.8.0

Comments

@gastaldi
Copy link

It would be nice if XmlAssert.assertThat() worked with java.nio.file.Path objects
@bodewig
Copy link
Member

bodewig commented Sep 21, 2020

Even though you mention it as an enhancement for the AssertJ module, it would probably be good to have NIO support in core's InputBuilder. Apart from Path we should probably support readable Channels as well.

The biggest hurdle here is that core currently wants to be Java 6 compatible. Maybe it is about time to change that.

@bodewig bodewig added this to the 2.8.0 milestone Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core enhancement good first issue
Projects
None yet
Milestone
2.8.0
Development

No branches or pull requests
2 participants
@gastaldi @bodewig